[JENKINS-73330] Fix dropdowns and tooltips on HDR displays #9654

janfaracik · 2024-08-24T15:25:31Z

Safari on macOS behaves a little differently to every other browser in that it turns on HDR when using the brightness(...) filter in CSS. This causes dropdowns, tooltips and dialogs to appear over exposed (and literally brighter) when working on a HDR display. It's pretty painful.

This PR fixes that, by removing the brightness() filter, and instead just setting the background on those elements to a semi translucent colour.

See #9649 for a fix to dialogs.

Testing done

Dropdowns and tooltips appear as expected, similar to how they did before, just not overblown

Proposed changelog entries

Fix dropdown and tooltip brightness on HDR displays.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

janfaracik · 2024-08-24T15:26:02Z

/label web-ui

NotMyFault

Good catch!

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[JENKINS-73330] Fix dropdowns and tooltips on HDR displays

aed3918

comment-ops-bot bot added the web-ui The PR includes WebUI changes which may need special expertise label Aug 24, 2024

NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Aug 25, 2024

NotMyFault approved these changes Aug 25, 2024

View reviewed changes

NotMyFault requested a review from a team August 25, 2024 08:50

timja approved these changes Aug 25, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 25, 2024

timja merged commit a304977 into jenkinsci:master Aug 26, 2024
15 checks passed

timja deleted the JENKINS-73330 branch August 26, 2024 09:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-73330] Fix dropdowns and tooltips on HDR displays #9654

[JENKINS-73330] Fix dropdowns and tooltips on HDR displays #9654

janfaracik commented Aug 24, 2024 •

edited by MarkEWaite

Loading

Submitter checklist

Maintainer checklist

janfaracik commented Aug 24, 2024

NotMyFault left a comment

timja left a comment

[JENKINS-73330] Fix dropdowns and tooltips on HDR displays #9654

[JENKINS-73330] Fix dropdowns and tooltips on HDR displays #9654

Conversation

janfaracik commented Aug 24, 2024 • edited by MarkEWaite Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

janfaracik commented Aug 24, 2024

NotMyFault left a comment

Choose a reason for hiding this comment

timja left a comment

Choose a reason for hiding this comment

janfaracik commented Aug 24, 2024 •

edited by MarkEWaite

Loading